Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Acir debug information #1864

Merged
merged 29 commits into from
Jul 12, 2023
Merged

feat: Add Acir debug information #1864

merged 29 commits into from
Jul 12, 2023

Conversation

guipublic
Copy link
Contributor

Description

Generates debug information for ACIR

Problem*

When a constraint is failing, the user has no clue on which constraint is failing.

Resolves

Summary*

Adds source location from the frontend in a map and use it to map acir opcodes to their corresponding location.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray changed the title feat: acir debug information feat: Add Acir debug information Jul 7, 2023
@jfecher
Copy link
Contributor

jfecher commented Jul 7, 2023

This looks a lot better now without the duplication of each insert_ function I think. I'm ready to approve once tests are fixed.

@guipublic
Copy link
Contributor Author

This looks a lot better now without the duplication of each insert_ function I think. I'm ready to approve once tests are fixed.

For the tests to work we need a new acvm versionI presume

jfecher
jfecher previously requested changes Jul 11, 2023
View reviewed changes
crates/nargo_cli/src/cli/compile_cmd.rs Outdated Show resolved Hide resolved
crates/nargo_cli/src/cli/compile_cmd.rs Outdated Show resolved Hide resolved
crates/nargo_cli/src/cli/execute_cmd.rs Outdated Show resolved Hide resolved
crates/nargo_cli/src/cli/execute_cmd.rs Outdated Show resolved Hide resolved
crates/nargo_cli/src/cli/execute_cmd.rs Show resolved Hide resolved
crates/noirc_errors/src/debug_info.rs Outdated Show resolved Hide resolved
crates/noirc_evaluator/src/ssa_refactor/ir/dfg.rs Show resolved Hide resolved
crates/noirc_evaluator/src/ssa_refactor/ssa_gen/context.rs Outdated Show resolved Hide resolved
crates/noirc_evaluator/src/ssa_refactor/ssa_gen/context.rs Outdated Show resolved Hide resolved
noir_stdlib/src/field.nr Outdated Show resolved Hide resolved
kevaundray
kevaundray approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevaundray kevaundray dismissed jfecher’s stale review July 12, 2023 21:27

spoke internally, addressed two outstanding comments by reverting tests and removing clone by following the suggessted action

@kevaundray kevaundray enabled auto-merge July 12, 2023 21:27
@kevaundray kevaundray added this pull request to the merge queue Jul 12, 2023
Merged via the queue into master with commit 5ff8b53 Jul 12, 2023
@kevaundray kevaundray deleted the gd/debug_location branch July 12, 2023 21:48
This was referenced Jul 12, 2023
Merged
Closed
@TomAFrench TomAFrench mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher left review comments

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guipublic @jfecher @kevaundray