Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up 9_conditional and 8_integration #1938

Closed
kevaundray opened this issue Jul 16, 2023 · 2 comments · Fixed by #2774
Closed

Split up 9_conditional and 8_integration #1938

kevaundray opened this issue Jul 16, 2023 · 2 comments · Fixed by #2774
Assignees
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

These are two tests in the end to end test folders. However they contain many edge cases and the program is generally large, making it hard to pinpoint a particular regression or edge case.

Happy Case

We split up the tests to only test one edge case at a time. We may need to rethink the purpose of this folder;

  • Some examples are showing off simple functionality
  • Some examples are regression tests

We could possibly have a folder just for regression tests and one for example programs, and or possibly have a separate examples repo that the compiler runs over to test a large corpus of programs.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added the enhancement New feature or request label Jul 16, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 16, 2023
@kevaundray
Copy link
Contributor Author

@guipublic assigning this to you -- this should also speed up tests, the more cores the machine has.

Note: the main reason we can do this is because we do not do proving anymore. Moreover, some of these regression end to end tests will likely move to be unit tests in the future, so having them split up will make it easier to transition

@guipublic
Copy link
Contributor

8_integration will be difficult to split. However, since It was based on sha256, and since we have a sha256 unit test, I think we can simply remove it.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants