Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify warning in conditional statement #585

Closed
kevaundray opened this issue Dec 14, 2022 · 1 comment
Closed

Clarify warning in conditional statement #585

kevaundray opened this issue Dec 14, 2022 · 1 comment
Labels
enhancement New feature or request nargo Noir's CLI development tool

Comments

@kevaundray
Copy link
Contributor

Problem

Here we state a warning, that the code snippet needs to be ran at the start of main, but there is no explanation as to why.

Solution

Speaking with Guillaume he noted:

If you move this snippet, it will still work but it will not be a regression anymore (i.e it will also work without the fix)

So the solution is to expand on the comment for future developers.

Alternatives considered

(Describe any alternative solutions you have considered.)

Additional context

(If applicable.)

@kevaundray kevaundray added enhancement New feature or request nargo Noir's CLI development tool labels Dec 14, 2022
@kevaundray
Copy link
Contributor Author

Closing this and tracking the general issue here: #1938

@kevaundray kevaundray closed this as not planned Won't fix, can't repro, duplicate, stale Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nargo Noir's CLI development tool
Projects
None yet
Development

No branches or pull requests

1 participant