Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Switch from HashMap to BTreeMap in merge_stores #2035

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix: Switch from HashMap to BTreeMap in merge_stores #2035

merged 1 commit into from
Jul 25, 2023

Conversation

vezenovm
Copy link
Contributor

Description

Problem*

Resolves issue with non-deterministic circuit bytecode when using HashMap for merge_stores

Summary*

Move from HashMap to BTreeMap in merge_stores

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray enabled auto-merge July 25, 2023 20:07
@vezenovm vezenovm mentioned this pull request Jul 25, 2023
Closed
@kevaundray kevaundray added this pull request to the merge queue Jul 25, 2023
@kevaundray kevaundray mentioned this pull request Jul 25, 2023
Merged
5 tasks
Merged via the queue into master with commit 4d179e3 Jul 25, 2023
@kevaundray kevaundray deleted the mv/merge-stores-btree branch July 25, 2023 20:52
@kevaundray kevaundray mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vezenovm @kevaundray