Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyclic dependencies cause nargo to stack overflow #2295

Closed
phated opened this issue Aug 11, 2023 · 0 comments · Fixed by #3699
Closed

Cyclic dependencies cause nargo to stack overflow #2295

phated opened this issue Aug 11, 2023 · 0 comments · Fixed by #3699
Assignees
@guipublic
Labels
bug Something isn't working

Comments

@phated
Copy link
Contributor

phated commented Aug 11, 2023

Aim

Nargo panics with a stack overflow when given the following TOML:

[package]
name = "baz"
type = "bin"
authors = [""]
compiler_version = "0.9.0"

[dependencies]
foo_bar = { path = "./" }

Expected Behavior

Dependency paths should be checked for cycles and a proper error should be given instead of panicing with a stack overflow

Bug

Panic instead of a good error message.

To Reproduce

Installation Method

None

Nargo Version

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Maybe

Support Needs

No response
@phated phated added the bug Something isn't working label Aug 11, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 11, 2023
@phated phated self-assigned this Aug 18, 2023
@phated phated removed their assignment Aug 25, 2023
@guipublic guipublic mentioned this issue Dec 6, 2023
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 3, 2024
@guipublic @kevaundray
fix: checks for cyclic dependencies (#3699)
642011a 
# Description

## Problem\*

Resolves #2295 

## Summary\*

Keep track of the processed packages and check against this list before
processing a new one.

## Additional Context



## Documentation\*

Check one:
- [X] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [X] I have tested the changes locally.
- [X] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guipublic guipublic

Labels
bug Something isn't working
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: checks for cyclic dependencies noir-lang/noir
3 participants
@phated @kevaundray @guipublic