Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save nightly build in github releases with date tags #2332

Closed
kevaundray opened this issue Aug 15, 2023 · 2 comments · Fixed by #2416
Closed

Save nightly build in github releases with date tags #2332

kevaundray opened this issue Aug 15, 2023 · 2 comments · Fixed by #2416
Assignees
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

Similar to Rust, it would be great to be able to do something like noirup -v nightly-2023-08-3

Our current workflow is that each night, we overwrite the nightly tag, so there is no convenient way to get the nightly release from two or three days ago.

This is mainly a problem for project whom don't want to build from source, and don't want to wait for a release but they want to use the latest features.

Happy Case

Each night when CI makes a release, it should tag the release artifacts with the date. It should also tag the latest release artifact with nightly so users can do noirup -v nightly to get the latest nightly version.

Note: we only need to store nighty versions for as long as our release schedule is. So if we release every two weeks, we only need to store nightlies for 2 weeks. We could perhaps just round it to 30 days so folks have time to switch their CI from nightly to stable.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added enhancement New feature or request P-MEDIUM labels Aug 15, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 15, 2023
@phated
Copy link
Contributor

phated commented Aug 16, 2023

Note: we only need to store nighty versions for as long as our release schedule is. So if we release every two weeks, we only need to store nightlies for 2 weeks. We could perhaps just round it to 30 days so folks have time to switch their CI from nightly to stable.

This is a short-sighted assumption. We'd need to store them forever to avoid breaking anyone's workflow that has these values hardcoded.

@kevaundray
Copy link
Contributor Author

I don't think we should make that guarantee with nightly builds -- users should not be trying to get stability with nightly builds, for that they should rely on a stable release version which does live forever.

I'm okay with increasing the retention period to something longer barring Github's storage limits

@phated phated self-assigned this Aug 18, 2023
@kobyhallx kobyhallx self-assigned this Aug 18, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants