Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Save nightly build in github releases with date tags #2416

Merged
merged 4 commits into from
Sep 16, 2023
Merged

feat: Save nightly build in github releases with date tags #2416

merged 4 commits into from
Sep 16, 2023

Conversation

dmvict
Copy link
Contributor

@dmvict dmvict commented Aug 23, 2023 •
edited by TomAFrench
Loading

Description

A solution to save nightly releases with date tag

Problem*

From issue:

Similar to Rust, it would be great to be able to do something like noirup -v nightly-2023-08-3
Our current workflow is that each night, we overwrite the nightly tag, so there is no convenient way to get the nightly release from two or three days ago.
This is mainly a problem for project whom don't want to build from source, and don't want to wait for a release but they want to use the latest features.

Resolves #2332

Summary*

Documentation

  • This PR requires no documentation updates when merged.

Additional Context

The step Get formatted date can be moved to job build-barretenberg and its output can be saved in job outputs. It reduces number of duplicates but the move will mix job purpose. Also we can create a separate job for the step.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

BEGIN_COMMIT_OVERRIDE
chore(ci): Save nightly build in github releases with date tags (#2416)
END_COMMIT_OVERRIDE

phated
phated previously requested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks noirup since it doesn't keep our rolling nightly

@kevaundray
Copy link
Contributor

Extending Blaine's comment; how does it solve this part of the issue:

Each night when CI makes a release, it should tag the release artifacts with the date. It should also tag the latest release artifact with nightly so users can do noirup -v nightly to get the latest nightly version.

Emphasis mine

?

@dmvict
Copy link
Contributor Author

dmvict commented Aug 24, 2023

Extending Blaine's comment; how does it solve this part of the issue:

Each night when CI makes a release, it should tag the release artifacts with the date. It should also tag the latest release artifact with nightly so users can do noirup -v nightly to get the latest nightly version.

Emphasis mine

?

Thank you @phated and @kevaundray

Yes, the update was incorrect. I fixed it in last commit. Please, review the new changes.

@dmvict dmvict requested a review from phated August 24, 2023 08:54
@dmvict
Copy link
Contributor Author

dmvict commented Sep 14, 2023

Hello @phated

I fixed the previous issues a time ago. Now I merged the new changes.

Please, review the changes and approve/add new comments.

@kevaundray kevaundray dismissed phated’s stale review September 16, 2023 23:24

separate step now added to upload binaries to a specific nightly tag

@kevaundray kevaundray added this pull request to the merge queue Sep 16, 2023
Merged via the queue into noir-lang:master with commit 4aa6b49 Sep 16, 2023
@kevaundray kevaundray mentioned this pull request Sep 16, 2023
Merged
TomAFrench added a commit that referenced this pull request Sep 20, 2023
@TomAFrench
Merge branch 'master' into tf/use-setup-node
b637e08 
* master:
  feat(traits): Type checking for Trait impl method signatures  (#2652)
  chore: split 9_conditional test case and remove 8_integration (#2751)
  chore(github): Add "Idea Action Plan" Issue template (#2736)
  feat(aztec-noir): abstract storage (#2750)
  feat: signed arithmetic (#2748)
  chore: encapsulate abstraction leaks from `bb` into new crate (#2747)
  feat: Variable liveness analysis for brillig (#2715)
  chore: noirjs integration testing (#2744)
  chore: Add rust-toolchain file & adapt nix for changes (#2686)
  chore: wrap backend info response in a struct instead of boxed closure (#2737)
  fix: check for literal overflows in expressions (#2742)
  fix: nightly js test (#2740)
  fix: keep the correct type for bitshift (#2739)
  chore: Make new daily nightly releases be pre-releases and non latest (#2735)
  chore: disabling display location section  (#2118)
  chore: add a workflow that tracks acvm version for integration tests (#2700)
  feat: Save nightly build in github releases with date tags (#2416)
  chore: Add unified linting setup for JS code and enforce in CI (#2728)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobyhallx kobyhallx kobyhallx left review comments

@kevaundray kevaundray kevaundray approved these changes

@phated phated Awaiting requested review from phated

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save nightly build in github releases with date tags
4 participants
@dmvict @kevaundray @phated @kobyhallx