chore: Add rust-toolchain file & adapt nix for changes #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
commented
Sep 13, 2023
phated
commented
Sep 13, 2023
phated
force-pushed
the
phated/reduce-nix
branch
from
52312a8 to
0a39332
Compare
This reverts commit 7f8ba13.
phated
force-pushed
the
phated/reduce-nix
branch
from
98c3f75 to
902e169
Compare
kobyhallx
reviewed
Sep 18, 2023
kobyhallx
reviewed
Sep 18, 2023
|
Wasm integration test run: https://github.com/noir-lang/noir/actions/runs/6226630424 |
TomAFrench
added a commit
that referenced
this pull request
Sep 20, 2023
* master: feat(traits): Type checking for Trait impl method signatures (#2652) chore: split 9_conditional test case and remove 8_integration (#2751) chore(github): Add "Idea Action Plan" Issue template (#2736) feat(aztec-noir): abstract storage (#2750) feat: signed arithmetic (#2748) chore: encapsulate abstraction leaks from `bb` into new crate (#2747) feat: Variable liveness analysis for brillig (#2715) chore: noirjs integration testing (#2744) chore: Add rust-toolchain file & adapt nix for changes (#2686) chore: wrap backend info response in a struct instead of boxed closure (#2737) fix: check for literal overflows in expressions (#2742) fix: nightly js test (#2740) fix: keep the correct type for bitshift (#2739) chore: Make new daily nightly releases be pre-releases and non latest (#2735) chore: disabling display location section (#2118) chore: add a workflow that tracks acvm version for integration tests (#2700) feat: Save nightly build in github releases with date tags (#2416) chore: Add unified linting setup for JS code and enforce in CI (#2728)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This adds a rust-toolchain file to the project.
I've also updated Nix flake to consume this file using the
Fenixinput instead of therust-overlayinput. This will bring the Nix setup closer to a "pure rustup" workflow.I also took the chance to remove everything that existed for running tests since they don't actually work in Nix anymore.
And I changed the
defaultpackage to be a combination ofnargo,noir_wasm, andnoirc_abi_wasm, which means runningnix build . -Lwill produce aresultdirectory that contains all of them. I think this should help with local testing of wasm since the tests often need artifacts from bothnoir_wasmandnoirc_abi_wasm. I could also see us not making this the default but instead anallpackage—thoughts?Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.