Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically bump Nargo + Noir.js versions in noir-starter #2990

Closed
jonybur opened this issue Oct 4, 2023 · 4 comments
Closed

Automatically bump Nargo + Noir.js versions in noir-starter #2990

jonybur opened this issue Oct 4, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@jonybur
Copy link
Contributor

jonybur commented Oct 4, 2023

After they are tested in CI to be compatible with the specific bb.js version locked in noir-starter.

Potential blocker: AztecProtocol/noir-starter#51, sync with Dev Rel on progress.

@Savio-Sou Savio-Sou added this to Noir Sep 12, 2023
@jonybur jonybur self-assigned this Oct 4, 2023
@jonybur jonybur converted this from a draft issue Oct 4, 2023
@kobyhallx
Copy link
Contributor

Lowered to Low Priority since we have test coverage from JS side which can be used as example. Not sure this should be done in automated way at all, let's discuss why?

@Savio-Sou Savio-Sou added the enhancement New feature or request label Oct 10, 2023
@Savio-Sou
Copy link
Collaborator

let's discuss why?

For ensuring noir-starter as the most up-to-date boilerplate for external devs to start coding.

Bumping scope can be to latest stables, rather than latest nightlies / master.

On priority, I'd consider this a High/Medium if it's quick to tackle (<1 day), if it takes more than that we can consider it as a Low.

@Savio-Sou
Copy link
Collaborator

Assigning P-LOW as it is an educational nice to have that does not block any works.

Guessing E-LOW.

@TomAFrench
Copy link
Member

Closing this as noir-starter shouldn't block Noir development. noir-starter can have a workflow which polls for newly released versions of the JS packages rather than us pushing out a new version to them.

@TomAFrench TomAFrench closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants