Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using noir_js #51

Closed
1 task done
Tracked by #2825
Savio-Sou opened this issue Sep 15, 2023 · 3 comments
Closed
1 task done
Tracked by #2825

Switch to using noir_js #51

Savio-Sou opened this issue Sep 15, 2023 · 3 comments
Assignees
@jonybur @signorecello
Labels
enhancement New feature or request

Comments

@Savio-Sou
Copy link
Member

Savio-Sou commented Sep 15, 2023 •
edited
Loading

Helpful Prerequisite
Preview Give feedback
  1. Epic: Noir.js first release noir-lang/noir#2711
    19 of 19
    js
    jonybur

Problem

noir-starter currently demonstrates the use of acvm_js, while the new noir_js is now released on NPM which could use a demonstration.

Happy Case

Update noir-starter to use noir_js.

Additional Context

noir_js is currently a wrapper for acvm_js and noirc_abi_wasm. acvm_js is used for Noir program execution (i.e. witness generation) and noirc_abi_wasm is a helper for encoding initial witness in preparation for execution / witness generation.

The compile_prove_verify.test.ts is a great reference for how to make use of noir_js.
@Savio-Sou Savio-Sou added the enhancement New feature or request label Sep 15, 2023
@Savio-Sou Savio-Sou added this to Noir Sep 15, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 15, 2023
@Savio-Sou Savio-Sou mentioned this issue Sep 15, 2023
Closed
@critesjosh
Copy link
Collaborator

@signorecello can you take this one?

@Savio-Sou Savio-Sou changed the title Switch to using Noir.js Switch to using noir_js Sep 18, 2023
@signorecello signorecello mentioned this issue Sep 19, 2023
Closed
This was referenced Sep 25, 2023
Closed
Merged
@jonybur jonybur mentioned this issue Oct 4, 2023
Closed
@jonybur jonybur self-assigned this Oct 4, 2023
@Savio-Sou
Copy link
Member Author

@signorecello good to call this closed with #54?

@signorecello
Copy link
Collaborator

yes sorry forgot to close it here

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonybur jonybur

@signorecello signorecello

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonybur @critesjosh @signorecello @Savio-Sou