Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Noir-js integration #54

Merged
merged 19 commits into from
Oct 5, 2023
Merged

feat: Noir-js integration #54

merged 19 commits into from
Oct 5, 2023

Conversation

kevaundray
Copy link
Contributor

Description

This is the integration PR for noir.js

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for noir-next-hardhat ready!

Name Link
🔨 Latest commit 9075935
🔍 Latest deploy log https://app.netlify.com/sites/noir-next-hardhat/deploys/651f13795035bf00088fc87b
😎 Deploy Preview https://deploy-preview-54--noir-next-hardhat.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@socket-security
Copy link

socket-security bot commented Sep 26, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@noir-lang/noir_js 0.16.0 None +4 7.47 MB noir-lang
next 13.5.4 eval, network, filesystem, shell, environment +19 1.1 GB vercel-release-bot
hardhat 2.18.0 filesystem, shell, environment +166 39.8 MB fvictorio
@types/react 18.2.25 None +3 1.6 MB types
@types/mocha 10.0.1...10.0.2 None +0/-0 96.3 kB types
@types/node 18.17.14...18.18.3 None +0/-0 3.8 MB types

🚮 Removed packages: @aztec/bb.js@0.7.5, @noir-lang/acvm_js@0.26.1, fflate@0.8.0, solidity-coverage@0.8.4

@socket-security
Copy link

socket-security bot commented Sep 26, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: next@13.5.4

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@Savio-Sou
Copy link
Member

This is for iterative development / testing purposes only right?

@kevaundray
Copy link
Contributor Author

This is for iterative development / testing purposes only right?

Yeah exactly

next-hardhat/test/index.ts Outdated Show resolved Hide resolved
@kevaundray
Copy link
Contributor Author

@SocketSecurity ignore next@13.5.3

@Savio-Sou
Copy link
Member

Resolves #51 when merged?

@signorecello
Copy link
Collaborator

@SocketSecurity ignore next@13.5.4

@signorecello signorecello merged commit 489c06f into main Oct 5, 2023
@signorecello signorecello deleted the kw/noir-js-integration branch October 5, 2023 20:05
@Savio-Sou Savio-Sou mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants