Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization changes do not recompute the artifacts if it already exists on file #3130

Closed
kevaundray opened this issue Oct 12, 2023 · 0 comments · Fixed by #3248
Closed
Assignees
Labels
bug Something isn't working

Comments

@kevaundray
Copy link
Contributor

kevaundray commented Oct 12, 2023

Aim

This bug was caught by Martín Verzilli.

When a serialization change is made, nargo does not check if the json artifact with the old bytecode is not compatible.

This can lead to users running nargo execute and arriving the program panicking when trying to deserialize the old bytecode with the new serialization format.

Expected Behavior

When a new noir version is made, regardless of whether it changed serialization, we should recompile the circuit. This also applies for nightly versions.

To get there, we need to tag each json file with an extra field "noir_version" and possibly "acvm_version". When we compile, we can check if the artifact is already there and then check the noir_version. If the noir_version has changed, then we recompile.

Bug

Currently it does not recompile.

To Reproduce

Installation Method

None

Nargo Version

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added the bug Something isn't working label Oct 12, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 12, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants