You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a serialization change is made, nargo does not check if the json artifact with the old bytecode is not compatible.
This can lead to users running nargo execute and arriving the program panicking when trying to deserialize the old bytecode with the new serialization format.
Expected Behavior
When a new noir version is made, regardless of whether it changed serialization, we should recompile the circuit. This also applies for nightly versions.
To get there, we need to tag each json file with an extra field "noir_version" and possibly "acvm_version". When we compile, we can check if the artifact is already there and then check the noir_version. If the noir_version has changed, then we recompile.
Bug
Currently it does not recompile.
To Reproduce
Installation Method
None
Nargo Version
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered:
Aim
This bug was caught by Martín Verzilli.
When a serialization change is made, nargo does not check if the json artifact with the old bytecode is not compatible.
This can lead to users running
nargo execute
and arriving the program panicking when trying to deserialize the old bytecode with the new serialization format.Expected Behavior
When a new noir version is made, regardless of whether it changed serialization, we should recompile the circuit. This also applies for nightly versions.
To get there, we need to tag each json file with an extra field "noir_version" and possibly "acvm_version". When we compile, we can check if the artifact is already there and then check the noir_version. If the noir_version has changed, then we recompile.
Bug
Currently it does not recompile.
To Reproduce
Installation Method
None
Nargo Version
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: