-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add version string to build artifacts #3156
Conversation
This won't work as we'll fail inside serde before we check the versions. We should just remove the unwraps when deserializing circuits and then if it returns an error, we disregard the build artifact. |
Good catch -- This PR would only deal with changes in Noir that do not modify serialization |
modified it to return an error -- if there is an error, then there is no CachedProgram and the program should recompile -- I'll do some testing by installing nargo with the version before your serialization changes and then compile with this version with the old artifacts |
const BACKEND_IDENTIFIER: &str = "acvm-backend-barretenberg"; | ||
|
||
const NOIR_ARTIFACT_VERSION_STRING: &str = | ||
concat!(env!("CARGO_PKG_VERSION"), "-", env!("GIT_COMMIT")); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two being here seems a bit odd -- I think versioning could probably go into the driver/nargo and then have it be shared between nargo_cli and wasm
Superceded by #3248 |
Description
Related to #3130
Problem*
Resolves
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.