Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hash_to_field blackbox function #3340

Closed
kevaundray opened this issue Oct 29, 2023 · 0 comments
Closed

Remove hash_to_field blackbox function #3340

kevaundray opened this issue Oct 29, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

With the merging of #3338 and #3339 we will no longer need the hash_to_field blackbox function.

Happy Case

Remove hash_to_field blackbox function and change docs to no longer say that it is a blackbox function.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added the enhancement New feature or request label Oct 29, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 29, 2023
guipublic added a commit to AztecProtocol/aztec-packages that referenced this issue Jan 5, 2024
Please provide a paragraph or two giving a summary of the change,
including relevant motivation and context.

Remove the HashToField128Security ACIR opcode from the codebase.
Resolve issue noir-lang/noir#3340

This PR encompass PR noir-lang/noir#3389 which
can be closed once this one is merged.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [X] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [X] Every change is related to the PR description.
- [X] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Jan 7, 2024
Please provide a paragraph or two giving a summary of the change,
including relevant motivation and context.

Remove the HashToField128Security ACIR opcode from the codebase.
Resolve issue noir-lang/noir#3340

This PR encompass PR noir-lang/noir#3389 which
can be closed once this one is merged.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [X] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [X] Every change is related to the PR description.
- [X] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Maddiaa0 pushed a commit to AztecProtocol/aztec-packages that referenced this issue Jan 8, 2024
Please provide a paragraph or two giving a summary of the change,
including relevant motivation and context.

Remove the HashToField128Security ACIR opcode from the codebase.
Resolve issue noir-lang/noir#3340

This PR encompass PR noir-lang/noir#3389 which
can be closed once this one is merged.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [X] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [X] Every change is related to the PR description.
- [X] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
Please provide a paragraph or two giving a summary of the change,
including relevant motivation and context.

Remove the HashToField128Security ACIR opcode from the codebase.
Resolve issue noir-lang/noir#3340

This PR encompass PR noir-lang/noir#3389 which
can be closed once this one is merged.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [X] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [X] Every change is related to the PR description.
- [X] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants