Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move module specific code out of the file manager #3799

Closed
kevaundray opened this issue Dec 13, 2023 · 0 comments · Fixed by #3806
Closed

Move module specific code out of the file manager #3799

kevaundray opened this issue Dec 13, 2023 · 0 comments · Fixed by #3806
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

In the file manager, there is code specifically related to the module system that should be put into dc_mod.

See the following two discussions:

Or search the file manager for the following two functions:

  • should_check_siblings_for_module
  • find_module

Happy Case

Move these to their callsite

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added enhancement New feature or request P-LOW labels Dec 13, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 13, 2023
@kevaundray kevaundray mentioned this issue Dec 13, 2023
Merged
5 tasks
@TomAFrench TomAFrench mentioned this issue Dec 14, 2023
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 14, 2023
@TomAFrench
chore: move module related code from fm to noirc-frontend (#3806)
49da769 
# Description

## Problem\*

Resolves #3799 

## Summary\*

This is a relatively quick and dirty resolution to #3799. We may want to
integrate these functions into `ModCollector` as methods but I think
they also work standalone plus it means that we can transfer the tests
across without needing to create a `ModCollector` instance.

## Additional Context


## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move module related code from fm to noirc-frontend noir-lang/noir
1 participant
@kevaundray