Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --expression_width flag to nargo compile #3854

Closed
kevaundray opened this issue Dec 18, 2023 · 2 comments · Fixed by #4117
Closed

Add --expression_width flag to nargo compile #3854

kevaundray opened this issue Dec 18, 2023 · 2 comments · Fixed by #4117
Assignees
@TomAFrench
Labels
enhancement New feature or request
Milestone
0.24

Comments

@kevaundray
Copy link
Contributor

kevaundray commented Dec 18, 2023 •
edited
Loading

Problem

This adds the ability to tell the compiler which expression width to use instead of getting it from the default backend

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added enhancement New feature or request P-LOW labels Dec 18, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 18, 2023
@TomAFrench
Copy link
Member

expression-width would be more accurate, no?

@kevaundray
Copy link
Contributor Author

Yep, I'll rename

@kevaundray kevaundray changed the title Add --program_width flag to nargo compile Add --expression_width flag to nargo compile Dec 19, 2023
@TomAFrench TomAFrench mentioned this issue Dec 19, 2023
Closed
@kevaundray kevaundray changed the title Add --expression_width flag to nargo compile Add --expression-width flag to nargo compile Jan 15, 2024
@kevaundray kevaundray changed the title Add --expression-width flag to nargo compile Add --expression_width flag to nargo compile Jan 15, 2024
@kevaundray kevaundray added this to the 0.24.0 milestone Jan 15, 2024
@TomAFrench TomAFrench mentioned this issue Jan 24, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 25, 2024
@TomAFrench @kevaundray
feat: add support for overriding expression width (#4117)
c8026d5 
# Description

## Problem\*

Resolves #3854 

## Summary\*

This PR adds the `expression-width` option to the CLI which allows users
to specify the expression width they want to use. Passing zero will
result in an unbounded width.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomAFrench TomAFrench

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
0.24
Development

Successfully merging a pull request may close this issue.

feat: add support for overriding expression width noir-lang/noir
3 participants
@TomAFrench @kevaundray @Savio-Sou