Remove SecondaryAttribute::Event

[kevaundray]

Problem

The enum variant SecondaryAttribute::Event is only used in the aztec_macros, we can remove this and use the is_custom_attribute function

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

[TomAFrench]

We still have the concept of an event in the main compiler however so it wouldn't be a clean removal.

noir/compiler/noirc_frontend/src/hir/def_map/mod.rs

Lines 195 to 205 in 57eae42

	let events = module
	.type_definitions()
	.filter_map(|id| {
	id.as_type().filter(|struct_id| {
	interner
	.struct_attributes(struct_id)
	.iter()
	.any(|attr| attr == &SecondaryAttribute::Event)
	})
	})
	.collect();

[kevaundray]

We still have the concept of an event in the main compiler however so it wouldn't be a clean removal.

noir/compiler/noirc_frontend/src/hir/def_map/mod.rs

Lines 195 to 205 in 57eae42

	let events = module
	.type_definitions()
	.filter_map(|id| {
	id.as_type().filter(|struct_id| {
	interner
	.struct_attributes(struct_id)
	.iter()
	.any(|attr| attr == &SecondaryAttribute::Event)
	})
	})
	.collect();

Yeah I think we'd need to have the concept of a primary attribute that is able to put things in the abi, ie #[abi(event)]

[asterite]

The attribute doesn't exist anymore so this issue can be closed.