Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put ExpressionWidth into the circuit definition #4012

Closed
kevaundray opened this issue Jan 11, 2024 · 1 comment
Closed

Put ExpressionWidth into the circuit definition #4012

kevaundray opened this issue Jan 11, 2024 · 1 comment
Assignees
@vezenovm @guipublic
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

It is not apparent if a circuit has been reduced or not, just by reading the bytecode

Happy Case

We can move ExpressionWidth into the ACIR structure to make this apparent.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added enhancement New feature or request P-LOW labels Jan 11, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 11, 2024
@kevaundray kevaundray assigned guipublic and vezenovm and unassigned guipublic Jan 11, 2024
@TomAFrench TomAFrench linked a pull request Jan 11, 2024 that will close this issue
chore!: Change Language -> ExpressionWidth and put ExpressionWidth into Circuit #3827
Closed
5 tasks
@guipublic guipublic mentioned this issue Jan 15, 2024
Merged
kevaundray added a commit to AztecProtocol/aztec-packages that referenced this issue Feb 5, 2024
@guipublic @kevaundray
feat!: Add expression width into acir (#4014)
f09e8fc 
Resolves Noir issue noir-lang/noir#4012, by
adding ExpressionWidth into acir.
The PR simply account for this new field and update the serialisation.
It also set the width during csat transformation phase.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Feb 6, 2024
@guipublic @kevaundray @AztecBot
feat!: Add expression width into acir (#4014)
ce6f451 
Resolves Noir issue noir-lang/noir#4012, by
adding ExpressionWidth into acir.
The PR simply account for this new field and update the serialisation.
It also set the width during csat transformation phase.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
TomAFrench pushed a commit to AztecProtocol/aztec-packages that referenced this issue Feb 7, 2024
@guipublic @kevaundray @TomAFrench
feat!: Add expression width into acir (#4014)
029146c 
Resolves Noir issue noir-lang/noir#4012, by
adding ExpressionWidth into acir.
The PR simply account for this new field and update the serialisation.
It also set the width during csat transformation phase.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@guipublic @kevaundray
feat!: Add expression width into acir (AztecProtocol#4014)
33f4bef 
Resolves Noir issue noir-lang/noir#4012, by
adding ExpressionWidth into acir.
The PR simply account for this new field and update the serialisation.
It also set the width during csat transformation phase.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
@vezenovm
Copy link
Contributor

vezenovm commented Mar 8, 2024

Closing as resolved by AztecProtocol/aztec-packages#4014

@vezenovm vezenovm closed this as completed Mar 8, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vezenovm vezenovm

@guipublic guipublic

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore!: Change Language -> ExpressionWidth and put ExpressionWidth into Circuit noir-lang/noir
4 participants
@kevaundray @vezenovm @guipublic @Savio-Sou