Chore: Remove nested slice code #4019
Comments
This was referenced Jan 11, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 17, 2024
# Description ## Problem\* Resolves #4019 ## Summary\* This removes the relevant code introduced for nested slices. This may be temporarily removed, but ultimately isn't too bad of a change as most of the code is contained to the fill internal slices pass with some extra logic in ACIR gen. ## Additional Context See issue for extra context. ## Documentation\* Check one: - [X] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [X] I have tested the changes locally. - [X] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
As a followup to #4017 we want to remove the nested slices code that has been intertwined into SSA and ACIR gen. This is potentially a temporary removal, but with nested slices being banned it adds extra confusion and complexity to leave the code in while we consider other solutions for nested slices.
Happy Case
There is no nested slices code in SSA or ACIR gen.
Alternatives Considered
We will look at potentially adding back in this code or using a new solution in due time. Aside from ACIR gen the nested slices code is mostly self contained in the
fill_internal_slicespass so it should be simple enough to add back in.Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: