Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BoundVec into the stdlib #4020

Closed
Tracked by #3363
vezenovm opened this issue Jan 11, 2024 · 0 comments · Fixed by #4197
Closed
Tracked by #3363

Move BoundVec into the stdlib #4020

vezenovm opened this issue Jan 11, 2024 · 0 comments · Fixed by #4197
Labels
enhancement New feature or request
Milestone
0.24

Comments

@vezenovm
Copy link
Contributor

vezenovm commented Jan 11, 2024 •
edited
Loading

Problem

The Aztec team has been leaning heavily in a custom data type called BoundedVec that is an attempt to mock slice/vec functionality using arrays, where essentially you can add to a Vec but that Vec has a max capacity.

Happy Case

Move BoundedVec into the stdlib for those who would like to use more complex slice/Vec logic.

Copy the BoundedVec implementation from https://github.com/AztecProtocol/aztec-packages/blob/1c8ea497fb1d64da64cb240917a60d57bd1efef8/yarn-project/noir-protocol-circuits/src/crates/types/src/utils/bounded_vec.nr#L1

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@vezenovm vezenovm added enhancement New feature or request P-MEDIUM labels Jan 11, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 11, 2024
@vezenovm vezenovm mentioned this issue Jan 11, 2024
Closed
@kevaundray kevaundray added this to the 0.24.0 milestone Jan 15, 2024
This was referenced Jan 29, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 29, 2024
@kevaundray @vezenovm
feat: Move bounded_vec into the noir stdlib (#4197)
c50621f 
# Description

Partially resolves #4020. 

Need to then remove from `aztec-packages` and move to this
implementation.

## Problem\*

Resolves <!-- Link to GitHub Issue -->

## Summary\*



## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Co-authored-by: vezenovm <mvezenov@gmail.com>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
0.24
Development

Successfully merging a pull request may close this issue.

feat: Move bounded_vec into the noir stdlib noir-lang/noir
3 participants
@kevaundray @vezenovm @Savio-Sou