Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL debugger stacktrace command #4025

Closed
mverzilli opened this issue Jan 12, 2024 · 0 comments · Fixed by #4184
Closed

REPL debugger stacktrace command #4025

mverzilli opened this issue Jan 12, 2024 · 0 comments · Fixed by #4184
Labels
enhancement New feature or request
Milestone
1.0

Comments

@mverzilli
Copy link
Contributor

Problem

The REPL debugger needs a way of inspecting the current execution stacktrace. While using the VS Code extension debugger this is not necessary given there's a dedicated UI pane to that end.

Happy Case

While debugging via the REPL, issuing a command stacktrace should print info about the current stack frame to the console.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response
@mverzilli mverzilli added the enhancement New feature or request label Jan 12, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 12, 2024
@mverzilli mverzilli mentioned this issue Jan 12, 2024
Closed
@kevaundray kevaundray added this to the 1.0 milestone Jan 15, 2024
AztecBot pushed a commit that referenced this issue Jan 15, 2024
@TomAFrench @kevaundray @AztecBot
chore: sync noir (#4025)
2d92108 
subrepo:
  subdir:   "noir"
  merged:   "0f38b229f"
upstream:
  origin:   "https://github.com/noir-lang/noir"
  branch:   "aztec-packages"
  commit:   "0f38b229f"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
@ggiraldez ggiraldez mentioned this issue Jan 26, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 8, 2024
@ggiraldez
feat: Allow variables and stack trace inspection in the debugger (#4184)
bf263fc 
# Description

## Problem\*

Part of #3015

Resolves #4025

## Summary\*

This PR adds several features to the debugger:
- (REPL) New command `stacktrace` to display the stack of the current
call frames.
- (REPL) New commands `over` and `out` to step to the next source code
location while staying without going into function calls or out of the
current stack frame.
- (DAP) The debugger commands "Step Into", "Step Out" and "Step Over"
now should work properly.
- (DAP) Return the stacktrace for the corresponding IDE panel.
- (DAP) Return the variables and Brillig registers for the corresponding
Variables panel in the IDE.

## Additional Context

## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [X] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [X] I have tested the changes locally.
- [X] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

feat: Allow variables and stack trace inspection in the debugger manastech/noir
2 participants
@mverzilli @kevaundray