Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add big integer opcode #4040

Closed
Tracked by #510
kevaundray opened this issue Jan 15, 2024 · 4 comments
Closed
Tracked by #510

Add big integer opcode #4040

kevaundray opened this issue Jan 15, 2024 · 4 comments
Assignees
@guipublic
Labels
enhancement New feature or request
Milestone
1.0

Comments

@kevaundray
Copy link
Contributor

Problem

These opcodes will allow us to implement big group, which would in turn allow us to implement higher level primitives like ecdsa

Happy Case

Add BigIntAdd, BigIntNeg, BigIntMul, BigIntInv

Alternatives Considered

No response

Additional Context

We should be careful about BigIntInv and think about whether we want to just limit the bigint modulus to be prime

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added the enhancement New feature or request label Jan 15, 2024
@kevaundray kevaundray added this to the 1.0 milestone Jan 15, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 15, 2024
@guipublic
Copy link
Contributor

Should we rather have BigIntDiv instead of BigIntInv?
BigIntDiv works for non prime modulus as well.

@kevaundray
Copy link
Contributor Author

Should we rather have BigIntDiv instead of BigIntInv?
BigIntDiv works for non prime modulus as well.

Yep lets go with Div!

@guipublic guipublic mentioned this issue Jan 16, 2024
Merged
guipublic added a commit to AztecProtocol/aztec-packages that referenced this issue Jan 24, 2024
@guipublic @kevaundray
feat!: Add big int opcodes (without implementation) (#4050)
bcab9ce 
Adds the biginteger opcode skeleton
noir-lang/noir#4040

The PR adds ACIR opcodes for bigint operations. It does not provide any
implantation of the opcodes, neither in BB, in the solver or in Brillig.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
AztecBot pushed a commit that referenced this issue Jan 24, 2024
@guipublic @kevaundray @AztecBot
feat!: Add big int opcodes (without implementation) (#4050)
7dba0a1 
Adds the biginteger opcode skeleton
#4040

The PR adds ACIR opcodes for bigint operations. It does not provide any
implantation of the opcodes, neither in BB, in the solver or in Brillig.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Jan 25, 2024
@guipublic @kevaundray @AztecBot
feat!: Add big int opcodes (without implementation) (#4050)
95cefa1 
Adds the biginteger opcode skeleton
noir-lang/noir#4040

The PR adds ACIR opcodes for bigint operations. It does not provide any
implantation of the opcodes, neither in BB, in the solver or in Brillig.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
@guipublic guipublic mentioned this issue Jan 25, 2024
Merged
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 30, 2024
@TomAFrench TomAFrench reopened this Jan 30, 2024
@TomAFrench
Copy link
Member

Reopening as the opcode doesn't have an implementation in ACVM

@Savio-Sou Savio-Sou moved this from ✅ Done to 🏗 In progress in Noir Feb 2, 2024
@Savio-Sou
Copy link
Collaborator

Closed with AztecProtocol/aztec-packages#4415.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Feb 15, 2024
@michaelelliot michaelelliot mentioned this issue Feb 20, 2024
Closed
@Savio-Sou Savio-Sou mentioned this issue Feb 22, 2024
Closed
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@guipublic @kevaundray
feat!: Add big int opcodes (without implementation) (AztecProtocol#4050)
70ff3e7 
Adds the biginteger opcode skeleton
noir-lang/noir#4040

The PR adds ACIR opcodes for bigint operations. It does not provide any
implantation of the opcodes, neither in BB, in the solver or in Brillig.

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guipublic guipublic

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
1.0
Development

No branches or pull requests
4 participants
@TomAFrench @kevaundray @guipublic @Savio-Sou