Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename function Symbol with LSP #4192

Closed
Tracked by #4191
kobyhallx opened this issue Jan 29, 2024 · 0 comments · Fixed by #4294
Closed
Tracked by #4191

Rename function Symbol with LSP #4192

kobyhallx opened this issue Jan 29, 2024 · 0 comments · Fixed by #4294

Comments

@kobyhallx
Copy link
Contributor

kobyhallx commented Jan 29, 2024

User should be able to rename symbol they work with, function name which leads to renaming all of the references across project.

Consider following:

File: baz.nr

1: pub fn foo() {}

File: main.nr

01: mod baz;
02: 
03: use baz::foo;
04: 
05: fn bar() {
06:     foo();
07: }
08: 
09: fn main() {
10:     foo();
11: } 

Choosing rename foo on line 10, should rename symbol on line 10, 06, 03 (import) and 1 on file baz.nr

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 29, 2024
@kobyhallx kobyhallx self-assigned this Jan 29, 2024
@kobyhallx kobyhallx changed the title Rename Symbol with LSP Rename function Symbol with LSP Feb 12, 2024
@kobyhallx kobyhallx self-assigned this Feb 12, 2024
@kobyhallx kobyhallx moved this from 📋 Backlog to 🏗 In progress in Noir Feb 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 2, 2024
# Description

## Problem\*

Resolves <!-- Link to GitHub Issue -->

Rename function Symbol with LSP #4192

## Summary\*

Allows to rename function symbol.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Jake Fecher <jfecher11@gmail.com>
Co-authored-by: jfecher <jake@aztecprotocol.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <tom@tomfren.ch>
Co-authored-by: Ary Borenszweig <asterite@gmail.com>
@asterite asterite closed this as completed Jul 2, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants