Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sha256 opcode #4330

Closed
guipublic opened this issue Feb 12, 2024 · 2 comments
Closed

Remove sha256 opcode #4330

guipublic opened this issue Feb 12, 2024 · 2 comments
Assignees
@guipublic
Labels
enhancement New feature or request

Comments

@guipublic
Copy link
Contributor

Problem

Sha256 is implemented with the sha256compression opcode in PR AztecProtocol/aztec-packages#4511
When this PR is merged, we no longer need the sha256 opcode

Happy Case

Just remove the sha256 opcode. The implementation with sha256 compression is more performant and allows us to have a variable size sha256

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@guipublic guipublic added the enhancement New feature or request label Feb 12, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 12, 2024
@guipublic guipublic self-assigned this Feb 13, 2024
@guipublic guipublic mentioned this issue Feb 13, 2024
Merged
@Savio-Sou Savio-Sou moved this from 📋 Backlog to 🏗 In progress in Noir Apr 19, 2024
@TomAFrench TomAFrench moved this from 🏗 In progress to 🚧 Blocked in Noir Apr 25, 2024
@Savio-Sou
Copy link
Collaborator

Pending for AVM's update to support SHA256 compression opcode, so we can safely deprecate this.

@TomAFrench TomAFrench moved this from 🚧 Blocked to 🏗 In progress in Noir May 3, 2024
@TomAFrench TomAFrench moved this from 🏗 In progress to 🚧 Blocked in Noir May 24, 2024
TomAFrench added a commit to AztecProtocol/aztec-packages that referenced this issue Sep 23, 2024
@guipublic @kevaundray
@TomAFrench @dbanks12 @fcarreiro
feat!: remove sha256 opcode (#4571)
4b4a0bf 
This PR resolves Noir issue 4330:
noir-lang/noir#4330
by removing the sha256 opcode and replacing the sha256 function in the
stdlib by the implementation using the sha256 compression opcode (also
in the stdlib).

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Co-authored-by: Tom French <tom@tomfren.ch>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: dbanks12 <david@aztecprotocol.com>
Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Co-authored-by: fcarreiro <facundo@aztecprotocol.com>
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Sep 24, 2024
@guipublic @kevaundray
@TomAFrench @dbanks12 @fcarreiro @AztecBot
feat!: remove sha256 opcode (#4571)
db6a399 
This PR resolves Noir issue 4330:
noir-lang/noir#4330
by removing the sha256 opcode and replacing the sha256 function in the
stdlib by the implementation using the sha256 compression opcode (also
in the stdlib).

---------

Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Co-authored-by: Tom French <tom@tomfren.ch>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: dbanks12 <david@aztecprotocol.com>
Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Co-authored-by: fcarreiro <facundo@aztecprotocol.com>
@github-project-automation github-project-automation bot moved this from 🚧 Blocked to ✅ Done in Noir Oct 24, 2024
@Savio-Sou
Copy link
Collaborator

Doesn't look like it need any, but do create an Issue if any updates to the SHA256 section in docs is necessary, thanks!
https://noir-lang.org/docs/dev/noir/standard_library/cryptographic_primitives/hashes#sha256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guipublic guipublic

Labels
enhancement New feature or request
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TomAFrench @guipublic @Savio-Sou