Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bit sizes in brillig binary operations should match the bit sizes of the operands #4369

Closed
Tracked by #4033
sirasistant opened this issue Feb 14, 2024 · 1 comment
Closed
Tracked by #4033

Bit sizes in brillig binary operations should match the bit sizes of the operands #4369

sirasistant opened this issue Feb 14, 2024 · 1 comment
Assignees
@sirasistant
Labels
brillig Unconstrained functions / brillig IR enhancement New feature or request

Comments

@sirasistant
Copy link
Contributor

No description provided.

@sirasistant sirasistant mentioned this issue Feb 14, 2024
Closed
12 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 14, 2024
@sirasistant sirasistant changed the title Bit sizes in binary operations should match the bit sizes of the operands Bit sizes in brillig binary operations should match the bit sizes of the operands Feb 14, 2024
@sirasistant sirasistant self-assigned this Feb 14, 2024
@sirasistant sirasistant added enhancement New feature or request brillig Unconstrained functions / brillig IR labels Feb 14, 2024
@sirasistant sirasistant mentioned this issue Feb 14, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 14, 2024
@sirasistant
fix: Consistent bit size for truncate (#4370)
dcd7a1e 
# Description

## Problem\*

Work towards #4369

## Summary\*

Uses consistent bit sizes for truncate and starts a refactor where we
start to track bit sizes for values in brillig IR

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@TomAFrench
Copy link
Member

Closed in #4391

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 16, 2024
@sirasistant sirasistant mentioned this issue Mar 13, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 13, 2024
@sirasistant
feat: Add checks for bit size consistency on brillig gen (#4542)
f3243b7 
# Description

## Problem\*

Adds checks for brillig codegen for #4369 (Previously we only had
consistency checks in SSA).

## Summary\*

This checks have caught some inconsistencies in the process, including
those that were caught manually in
AztecProtocol/aztec-packages#5091

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirasistant sirasistant

Labels
brillig Unconstrained functions / brillig IR enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sirasistant @TomAFrench