Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring nested recursion example into noir-lang/noir #4410

Open
1 task done
Savio-Sou opened this issue Feb 22, 2024 · 8 comments
Open
1 task done

Bring nested recursion example into noir-lang/noir #4410

Savio-Sou opened this issue Feb 22, 2024 · 8 comments
Assignees
@jzaki
Labels
CI documentation Improvements or additions to documentation enhancement New feature or request recursion Recursive proving / proof aggregation

Comments

@Savio-Sou
Copy link
Collaborator

Savio-Sou commented Feb 22, 2024 •
edited
Loading

Prerequisites
Preview Give feedback
  1. example code of recursive proof AztecProtocol/dev-rel#207
@Savio-Sou Savio-Sou added documentation Improvements or additions to documentation recursion Recursive proving / proof aggregation labels Feb 22, 2024
@Savio-Sou Savio-Sou added this to Noir Feb 22, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 22, 2024
@CodeDragonVN CodeDragonVN mentioned this issue Mar 2, 2024
Merged
3 tasks
@Savio-Sou Savio-Sou changed the title Update the "Recursion on NoirJS" how-to guide according to v0.24.0-friendly noir-example Update the "Recursion on NoirJS" how-to guide according to v0.25.0-friendly noir-example Mar 13, 2024
@Savio-Sou Savio-Sou moved this from 📋 Backlog to 🏗 In progress in Noir Mar 13, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 21, 2024
@CodeDragonVN @critesjosh
chore: update docs with function names to match version 0.25.0 specif…
6271b8b 
…ications (#4466)

# Description

## Problem

Other how-to guides not mentioned in #4410 need to be updated to the
v0.24.0 function naming.

## Summary

This pull request updates the documentation to match the function naming
conventions introduced in version 0.24.0. Specifically, it changes
references from `generateFinalProof` and `verifyFinalProof` to
`generateProof` and `verifyProof` respectively.

## Additional Context

The changes were made across multiple documentation files, including
tutorials and how-to guides.

## Documentation

- [x] Documentation included in this PR.

# PR Checklist

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: josh crites <jc@joshcrites.com>
TomAFrench pushed a commit that referenced this issue Apr 3, 2024
@CodeDragonVN @critesjosh @TomAFrench
chore: update docs with function names to match version 0.25.0 specif…
3c74a0e 
…ications (#4466)

# Description

## Problem

Other how-to guides not mentioned in #4410 need to be updated to the
v0.24.0 function naming.

## Summary

This pull request updates the documentation to match the function naming
conventions introduced in version 0.24.0. Specifically, it changes
references from `generateFinalProof` and `verifyFinalProof` to
`generateProof` and `verifyProof` respectively.

## Additional Context

The changes were made across multiple documentation files, including
tutorials and how-to guides.

## Documentation

- [x] Documentation included in this PR.

# PR Checklist

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: josh crites <jc@joshcrites.com>
@Savio-Sou Savio-Sou changed the title Update the "Recursion on NoirJS" how-to guide according to v0.25.0-friendly noir-example Update the "Recursion on NoirJS" how-to guide with v0.26.0 example Apr 24, 2024
@Savio-Sou Savio-Sou mentioned this issue Apr 24, 2024
Closed
@jzaki
Copy link
Contributor

jzaki commented Apr 29, 2024 •
edited
Loading

Details from Tom:

  • A top-level examples would also be fine for now (later docs/examples with docs moved to docs/site)
  • Remove use of codegen command
  • We'll need to have them pull the dependencies from the workspace rather than being fixed to a particular npm version.
    • If we're referencing the package.json in the docs then we're going to need to swap out the dependencies for the npm versions when pushing a new release.
  • We're going to need to run these as part of CI so we can enforce that the code still works and we can fix as needed.

@jzaki jzaki mentioned this issue May 3, 2024
Closed
5 tasks
@Savio-Sou Savio-Sou mentioned this issue May 22, 2024
Merged
5 tasks
@Savio-Sou Savio-Sou changed the title Update the "Recursion on NoirJS" how-to guide with v0.26.0 example Update the "Recursion on NoirJS" how-to guide May 23, 2024
@Savio-Sou
Copy link
Collaborator Author

Savio-Sou commented May 23, 2024 •
edited
Loading

Following #5072, proving and verification workflow would be scoped out of NoirJS.

The PR includes updates to the doc page. Commenting here for @noir-lang/developerrelations and readers' awareness in case it leads to changes to existing / planned works with respect to this Issue.

@Savio-Sou Savio-Sou changed the title Update the "Recursion on NoirJS" how-to guide Update the "Recursion on NoirJS" how-to guide with v0.26.0 example May 23, 2024
@Savio-Sou Savio-Sou changed the title Update the "Recursion on NoirJS" how-to guide with v0.26.0 example Bring nested recursion example into noir-lang/noir May 24, 2024
@Savio-Sou Savio-Sou added enhancement New feature or request CI labels May 24, 2024
@critesjosh
Copy link
Contributor

if not done by the end of the week, moving to blocked

@jzaki
Copy link
Contributor

jzaki commented Jun 20, 2024

Yeah, issue relayed again to Noir team. Now blocked until workaround/fix found.

@Savio-Sou
Copy link
Collaborator Author

@jzaki could you link me to the relevant noir-lang/noir or AztecProtocol/aztec-packages Issue?

@jzaki
Copy link
Contributor

jzaki commented Jun 21, 2024 •
edited
Loading

Okay, with a little tip form Tom, I did get it to pass, but by doing something that seems wrong and different to between what nargo returns and bb expects between binary vs js. I'll check with Tom this morning and create an issue for the lack of intuition on the .js side to document, or an issue for the .js side to be aligned with the binaries' way.

@jzaki
Copy link
Contributor

jzaki commented Jul 22, 2024

Added two benchmark circuits from Savio, 2^17 succeeds, 2^18 fails. The recursion test is skipped.
PR here

Once 2^18 works again, the skipped recursion tests should readily be made to pass again, so can unskip it and remove the benchmark tests.

@Savio-Sou
Copy link
Collaborator Author

Savio-Sou commented Jul 22, 2024 •
edited
Loading

Thanks @jzaki.

2^18 fails

If you have time it might be good to file an Issue for it in https://github.com/AztecProtocol/aztec-packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzaki jzaki

Labels
CI documentation Improvements or additions to documentation enhancement New feature or request recursion Recursive proving / proof aggregation
Projects
Noir
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add recursive example noir-lang/noir
3 participants
@jzaki @critesjosh @Savio-Sou