You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR AztecProtocol/aztec-packages#4571 is failing CI because it reaches a stack overflow during the ssa flatenning.
I managed to get a minimal repro with the following code:
fn main(x: u8, result: [u8; 32]) {
let mut digest = [0;32];
for i in 0..70 {
let y = x+i;
let a = [y ,x,32,0,y+1,y-1,2*y,5];
digest = std::sha256::digest(a);
}
assert(digest == result);
}
Happy Case
The flattening pass is using recursion and should be changed into an iterative version
Project Impact
None
Impact Context
No response
Workaround
None
Workaround Description
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
Yes
Support Needs
No response
The text was updated successfully, but these errors were encountered:
# Description
## Problem\*
Resolves#4449
## Summary\*
The issue is fixed by implementing an iterative version of the
flattening pass.
## Additional Context
## Documentation\*
Check one:
- [X] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.
# PR Checklist\*
- [X] I have tested the changes locally.
- [X] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
---------
Co-authored-by: jfecher <jake@aztecprotocol.com>
# Description
## Problem\*
Related to issue #4449
## Summary\*
This PR adds a regression test which ensure PR #4492 is able to handle
large CFG.
## Additional Context
## Documentation\*
Check one:
- [X] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.
# PR Checklist\*
- [X ] I have tested the changes locally.
- [ X] I have formatted the changes with
[Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Problem
The PR AztecProtocol/aztec-packages#4571 is failing CI because it reaches a stack overflow during the ssa flatenning.
I managed to get a minimal repro with the following code:
Happy Case
The flattening pass is using recursion and should be changed into an iterative version
Project Impact
None
Impact Context
No response
Workaround
None
Workaround Description
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
Yes
Support Needs
No response
The text was updated successfully, but these errors were encountered: