Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type aliases cannot be used in main function signature #4500

Closed
TomAFrench opened this issue Mar 7, 2024 · 1 comment · Fixed by #4505
Closed

Type aliases cannot be used in main function signature #4500

TomAFrench opened this issue Mar 7, 2024 · 1 comment · Fixed by #4505
Labels
bug Something isn't working

Comments

@TomAFrench
Copy link
Member

Aim

I'm trying to compile the program

type Foo = u8;

fn main(x: Foo) {

}

Expected Behavior

Should compile successfully

Bug

Compilation fails with error

error: Only sized types may be used in the entry point to a program
  ┌─ /home/tom/Programming/aztec/noir/temp/src/main.nr:3:12
  │
3 │ fn main(x: Foo) {
  │            --- Slices, references, or any type containing them may not be used in main or a contract function
  │

To Reproduce

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Installation Method

None

Nargo Version

No response

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@TomAFrench TomAFrench added the bug Something isn't working label Mar 7, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Mar 7, 2024
@jfecher
Copy link
Contributor

jfecher commented Mar 7, 2024

github-merge-queue bot pushed a commit that referenced this issue Mar 7, 2024
# Description

## Problem\*

Resolves #4500

## Summary\*

This was due to this check
https://github.com/noir-lang/noir/blob/master/compiler/noirc_frontend/src/hir_def/types.rs#L706-L709
which was needed since we checked if types were valid for main during
name resolution - which is before we know type aliases are not cyclic.
I've moved this check to type checking instead.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants