Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs contains dead links #4598

Closed
github-actions bot opened this issue Mar 20, 2024 · 2 comments · Fixed by #4606
Closed

Docs contains dead links #4598

github-actions bot opened this issue Mar 20, 2024 · 2 comments · Fixed by #4606
Assignees
@jzaki @critesjosh @signorecello @catmcgee @Savio-Sou
Labels
documentation Improvements or additions to documentation

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024 •
edited
Loading

Some of the external links in the docs are now dead. This is likely due to the thing being linked to being moved.

Check the Check Markdown links workflow for details.

This issue was raised by the workflow Check Markdown links
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 20, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Mar 20, 2024
@Savio-Sou
Copy link
Collaborator

From the workflow:

  1. https://github.com/AztecProtocol/aztec-packages/tree/master/yarn-project/noir-contracts/contracts

FILE: ./docs/versioned_docs/version-v0.17.0/modules_packages_crates/crates_and_packages.md
[✖] https://github.com/AztecProtocol/aztec-packages/tree/master/yarn-project/noir-contracts/contracts

FILE: ./docs/versioned_docs/version-v0.19.0/modules_packages_crates/crates_and_packages.md
[✖] https://github.com/AztecProtocol/aztec-packages/tree/master/yarn-project/noir-contracts/contracts

FILE: ./docs/versioned_docs/version-v0.19.1/modules_packages_crates/crates_and_packages.md
[✖] https://github.com/AztecProtocol/aztec-packages/tree/master/yarn-project/noir-contracts/contracts

FILE: ./docs/versioned_docs/version-v0.19.2/modules_packages_crates/crates_and_packages.md
[✖] https://github.com/AztecProtocol/aztec-packages/tree/master/yarn-project/noir-contracts/contracts

FILE: ./docs/versioned_docs/version-v0.19.3/modules_packages_crates/crates_and_packages.md
[✖] https://github.com/AztecProtocol/aztec-packages/tree/master/yarn-project/noir-contracts/contracts

FILE: ./docs/versioned_docs/version-v0.19.4/modules_packages_crates/crates_and_packages.md
[✖] https://github.com/AztecProtocol/aztec-packages/tree/master/yarn-project/noir-contracts/contracts

FILE: ./docs/versioned_docs/version-v0.22.0/noir/modules_packages_crates/crates_and_packages.md
[✖] https://github.com/AztecProtocol/aztec-packages/tree/master/yarn-project/noir-contracts/contracts

FILE: ./docs/versioned_docs/version-v0.23.0/noir/modules_packages_crates/crates_and_packages.md
[✖] https://github.com/AztecProtocol/aztec-packages/tree/master/yarn-project/noir-contracts/contracts

FILE: ./docs/versioned_docs/version-v0.24.0/noir/modules_packages_crates/crates_and_packages.md
[✖] https://github.com/AztecProtocol/aztec-packages/tree/master/yarn-project/noir-contracts/contracts

  1. https://play.noir-lang.org/

FILE: ./docs/versioned_docs/version-v0.22.0/getting_started/tooling/index.md
[✖] https://play.noir-lang.org/

  1. https://github.com/noir-lang/noir/blob/master/crates/nargo_cli/tests/test_data/generics/src/main.nr

FILE: ./docs/versioned_docs/version-v0.19.0/language_concepts/06_generics.md
[✖] https://github.com/noir-lang/noir/blob/master/crates/nargo_cli/tests/test_data/generics/src/main.nr

@critesjosh
Copy link
Contributor

updating this now

@critesjosh critesjosh mentioned this issue Mar 21, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 9, 2024
@critesjosh
chore(doc): Fix broken docs links (#4606)
ac1c33e 
# Description

## Problem\*

Resolves #4598 

## Summary\*



## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzaki jzaki

@critesjosh critesjosh

@signorecello signorecello

@catmcgee catmcgee

@Savio-Sou Savio-Sou

Labels
documentation Improvements or additions to documentation
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(doc): Fix broken docs links noir-lang/noir
5 participants
@jzaki @critesjosh @signorecello @catmcgee @Savio-Sou