Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for malicious strings in lexing #4613

Closed
michaeljklein opened this issue Mar 21, 2024 · 0 comments · Fixed by #4617
Closed

Add tests for malicious strings in lexing #4613

michaeljklein opened this issue Mar 21, 2024 · 0 comments · Fixed by #4617
Assignees
@michaeljklein

Comments

@michaeljklein
Copy link
Contributor

michaeljklein commented Mar 21, 2024 •
edited
Loading

Use the Big List of Naughty Strings (BLNS) to test the lexer.

Specifically, given x, a string from the BLNS, check successful lexing of the following:

  • Raw: x
  • String: "x"
  • Raw string: r"x"
  • Ident: let x = ()
  • Comment: // x
  • etc.
@Savio-Sou Savio-Sou added this to Noir Mar 21, 2024
@michaeljklein michaeljklein self-assigned this Mar 21, 2024
@michaeljklein michaeljklein converted this from a draft issue Mar 21, 2024
@michaeljklein michaeljklein mentioned this issue Mar 21, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 29, 2024
@michaeljklein @jfecher
chore: add big list of naughty strings test for lexer (#4617)
c08cc4f 
# Description

## Problem\*

Resolves #4613

## Summary\*

Converts BLNS items into simple test programs and runs them through the
lexer.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: jfecher <jake@aztecprotocol.com>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Mar 29, 2024
TomAFrench pushed a commit that referenced this issue Apr 3, 2024
@michaeljklein @jfecher @TomAFrench
chore: add big list of naughty strings test for lexer (#4617)
c1f279f 
# Description

## Problem\*

Resolves #4613

## Summary\*

Converts BLNS items into simple test programs and runs them through the
lexer.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: jfecher <jake@aztecprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaeljklein michaeljklein

Labels
None yet
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add big list of naughty strings test for lexer noir-lang/noir
1 participant
@michaeljklein