Noir JS: Utilize new program execution functions from ACVM JS #4706
Labels
Comments
Closed
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
May 3, 2024
# Description ## Problem\* Resolves #4706 ## Summary\* This PR actually does not do too much as we still use `executeCircuitWithBlackBoxSolver` throughout the ACIR simulator on aztec. That should be removed separately before we look to remove it from ACVM JS. Noir JS backend also needs to wait for the barretenberg interface updates before we can pass a collection of circuits to the backend. ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
After #4645 is resolved we will be able to execution a program of circuits rather than full a single circuit. Noir JS still uses
executeCircuitandexecuteCircuitWithBlackBoxSolverinternally.Happy Case
We should move to using the new execute program methods in ACVM JS. Then we can break the ACVM JS interface and remove
executeCircuitandexecuteCircuitWithBlackBoxSolver.Project Impact
None
Impact Context
Noir JS users will be able to take advantage of full program execution which is necessary for any backends integrating folding.
Workaround
None
Workaround Description
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: