Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborator doesn't correctly detect we are in_contract #5288

Closed
Thunkar opened this issue Jun 19, 2024 · 0 comments · Fixed by #5292
Closed

Elaborator doesn't correctly detect we are in_contract #5288

Thunkar opened this issue Jun 19, 2024 · 0 comments · Fixed by #5292
Labels
bug Something isn't working

Comments

@Thunkar
Copy link
Contributor

Thunkar commented Jun 19, 2024

Aim

Compile aztec packages with the new elaborator

Expected Behavior

contract ElaboratorContract {
    #[recursive]
    fn contract_entrypoint() -> Field {
        1
    }
}

This should compile

Bug

The new elaborator doesn't correctly detect we are inside a contract, and as such every check for entrypoint functions fail. Most obvious errors come from trying to use attributes such as #[recursive] or #[abi(tag)]

To Reproduce

Try to compile the example above, the compiler will return
Screenshot 2024-06-19 at 12 03 31

Project Impact

Blocker

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Installation Method

Compiled from source

Nargo Version

No response

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@Thunkar Thunkar added the bug Something isn't working label Jun 19, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 19, 2024
@TomAFrench TomAFrench changed the title bug: Elaborator doesn't correctly detect we are in_contract Elaborator doesn't correctly detect we are in_contract Jun 19, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 20, 2024
…laborator (#5292)

…

# Description

## Problem\*

Resolves #5288 

## Summary\*

This PR fixes #5288 by updating `self.in_contract` before we define
function metadata to match `self.local_module`. This is mildly hacky and
we may want to have a nicer "switch modules and update everything which
depends on it" helper function in future.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant