Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quoted::as_trait_constraint method #5481

Closed
Tracked by #4594
jfecher opened this issue Jul 10, 2024 · 0 comments · Fixed by #5499
Closed
Tracked by #4594

Add Quoted::as_trait_constraint method #5481

jfecher opened this issue Jul 10, 2024 · 0 comments · Fixed by #5499
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Jul 10, 2024

Problem

We need a way of converting Quoted token streams into trait constraints when quoted values are given as arguments to annotations.

Happy Case

We should add a Quoted::as_trait_constraint conversion method.

For now we can error if it cannot be converted to a trait constraint. In the future we may likely want to return a Option<TraitConstraint> instead. This lets the user continue if it was not a valid trait constraint, but the error message they can give will be less specific than the one we can give in the compiler.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the enhancement New feature or request label Jul 10, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 10, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 17, 2024
jzaki pushed a commit that referenced this issue Jul 17, 2024
# Description

## Problem\*

Resolves #5480
Resolves #5481

## Summary\*

Adds:
- The `TraitConstraint` type
- `impl Eq for TraitConstraint`
- `impl Hash for TraitConstraint`
- `Quoted::as_trait_constraint`

## Additional Context

Ran into the type error when calling trait impls issue again while
working on this. Hence why it is a draft.

## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [x] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant