Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: allowing inserting inlay type hints #5527

Closed
asterite opened this issue Jul 17, 2024 · 0 comments · Fixed by #5620
Closed

LSP: allowing inserting inlay type hints #5527

asterite opened this issue Jul 17, 2024 · 0 comments · Fixed by #5620
Assignees
Labels
enhancement New feature or request

Comments

@asterite
Copy link
Collaborator

Problem

#5510 added inlay type hints but you can't double click on them to insert them. This issue is about doing that.

Happy Case

Double-clicking on an inlay type hint inserts it, and immediately the old type hint disappears.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@asterite asterite added the enhancement New feature or request label Jul 17, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 17, 2024
@asterite asterite self-assigned this Jul 29, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 29, 2024
# Description

## Problem

Resolves #5527

## Summary

Makes type hints insertable, though not all of them can be inserted. For
example a for variable can't have a type annotation, and a struct member
pattern can't either.

I also added a test for when the type hint is shown for a struct member
pattern, which was missing (mainly to assert that the type there isn't
insertable).



https://github.com/user-attachments/assets/b3a02f2b-be82-49b5-9ac5-cebf8cb83214



## Additional Context

None.

## Documentation

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant