-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for improvements to contract verifier how-to #5711
Comments
Please add this to your docs: https://github.com/AztecProtocol/aztec-packages/blob/ss/doc-bb-honk/barretenberg/cpp/src/barretenberg/bb/readme.md#usage-with-ultrahonk These docs are very misleading: https://noir-lang.org/docs/how_to/how-to-solidity-verifier |
This command was removed as the verifier contract is specific to a particular proving backend. Nargo no longer handles communication with the proving backend in order to make it easier to use 3rd party backends, and so the contract must be generated on the backend directly. |
We do link to the BB docs when we introduce usage of bb in our documentation. https://noir-lang.org/docs/dev/getting_started/backend/ https://noir-lang.org/docs/dev/getting_started/hello_noir/#proving-backend cc @noir-lang/developerrelations on issues with contract verifier tutorial. |
Yes, I found how to generate a proving contract, this is at the bottom of @TomAFrench Also how to pass the a proof to the generated contract to verify? There used to be a file with a |
@partylikeits1983 from what i understand, the info that you are looking for is included in Step 1 of the page. The information that follows is meant to demonstrate how you could interact with the verifier. I opened a PR to make it easier to find more info about @Savio-Sou do we want to add instructions for generating solidity verifiers with ultrahonk yet? |
@critesjosh I haven't personally figured out how to extract public inputs from Honk proofs yet, but we are clear to document it is expected to work from Noir v0.33.0 + bb v0.47.1 onwards. Will defer to your team on is updating the how-to in Noir docs worthwhile in terms of LearnEx vs sustainable feasibility (i.e. if we need to consider migrating content to bb's README). |
…verifier page (#5754) # Description ## Problem\* Resolves #5711 ## Summary\* ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [x] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Problem
I used Noir 3 months ago, the running
nargo codegen-verifier
created a solidity verifier. Now this feature was removed.Happy Case
nargo codegen-verifier
should result in a solidity verifier. Why move it to some npm package?? Now my project needs a forge.toml, cargo.toml, and a package.json??? Additionally the docs got worse, they assume developers who use noir will use remixIDE?Workaround
Yes
Workaround Description
Search for 30 minutes how to generate a solidity verifier.
Additional Context
No response
Project Impact
Blocker
Blocker Context
Why remove useful features?
Would you like to submit a PR for this Issue?
Maybe
Support Needs
No response
The text was updated successfully, but these errors were encountered: