Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No impl Eq for u16 #5733

Closed
jfecher opened this issue Aug 15, 2024 · 0 comments · Fixed by #5738
Closed

No impl Eq for u16 #5733

jfecher opened this issue Aug 15, 2024 · 0 comments · Fixed by #5738
Assignees
@TomAFrench
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Aug 15, 2024

Aim

fn main() {
    let one: u16 = 1;
    let _ = (one, 1) == (1, 1);
}

Expected Behavior

The program to execute successfully

Bug

The cmp traits don't have implementations for u16 or i16 since it was added later.

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@jfecher jfecher added the bug Something isn't working label Aug 15, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 15, 2024
@TomAFrench TomAFrench mentioned this issue Aug 16, 2024
Merged
5 tasks
@TomAFrench TomAFrench self-assigned this Aug 16, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 19, 2024
@TomAFrench
fix: add missing trait impls for integer types to stdlib (#5738)
d3f20c6 
# Description

## Problem\*

Resolves #5733 

## Summary\*

This PR implements some missing trait implementations for numeric types.
This covers `u16` as mentioned in the issue but also `u1`s

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomAFrench TomAFrench

Labels
bug Something isn't working
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add missing trait impls for integer types to stdlib noir-lang/noir
2 participants
@jfecher @TomAFrench