Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl Hash and Eq for metaprogramming types #6012

Closed
Thunkar opened this issue Sep 12, 2024 · 0 comments · Fixed by #6022
Closed

impl Hash and Eq for metaprogramming types #6012

Thunkar opened this issue Sep 12, 2024 · 0 comments · Fixed by #6022
Labels
enhancement New feature or request

Comments

@Thunkar
Copy link
Contributor

Thunkar commented Sep 12, 2024 •
edited
Loading

Problem

Just like TraitImpl, it would be great to have a builtin hasher for:

  • Module
  • Type
  • StructDefinition
  • FunctionDefinition

So that we can use the comptime mut global HASHMAP: UHashMap<...> pattern with all meta types and register them for later use without duplicates.

Happy Case

Type.hash(), StructDefinition.hash() etc exist

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

Blocker

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@Thunkar Thunkar added the enhancement New feature or request label Sep 12, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 12, 2024
@jfecher jfecher changed the title Hash builtin for metaprogramming types impl Hash and Eq for metaprogramming types Sep 12, 2024
@jfecher jfecher mentioned this issue Sep 12, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 12, 2024
@jfecher
feat: impl Hash and Eq on more comptime types (#6022)
114903d 
# Description

## Problem\*

Resolves #6012

## Summary\*

Implements Hash and Eq for a number of comptime types, including a few
that had Eq but not Hash.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [x] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: impl Hash and Eq on more comptime types noir-lang/noir
1 participant
@Thunkar