Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arithmetic generics N term being lost #6032

Closed
jfecher opened this issue Sep 13, 2024 · 0 comments · Fixed by #6033
Closed

Arithmetic generics N term being lost #6032

jfecher opened this issue Sep 13, 2024 · 0 comments · Fixed by #6033
Assignees
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Sep 13, 2024

Aim

struct ArrData<let N: u32> {
    a: [Field; N],
    b: [Field; N + N - 1],
}
fn main() {
    let _f: ArrData<5> = ArrData {
        a: [0; 5],
        b: [0; 9],
    };
}

Expected Behavior

The program to type check

Bug

error: Expected type [Field; 4], found type [Field; 9] pointing to b

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the bug Something isn't working label Sep 13, 2024
@jfecher jfecher self-assigned this Sep 13, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 13, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 13, 2024
# Description

## Problem\*

Resolves #6032

## Summary\*

This issue was because when we sort commutative terms we sorted them in
a BTreeSet, but this meant any identical terms were deduplicated. I
changed it to keep track of how many of each term there was so that we
don't accidentally change the expression when canonicalizing it.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant