Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unused struct warning #6055

Closed
asterite opened this issue Sep 17, 2024 · 0 comments · Fixed by #6061
Closed

Improve unused struct warning #6055

asterite opened this issue Sep 17, 2024 · 0 comments · Fixed by #6061
Labels
enhancement New feature or request

Comments

@asterite
Copy link
Collaborator

Problem

Right now the unused struct warning will not trigger if the struct has some impls:

struct Foo {} // No warning here
impl Foo {}

Happy Case

The above code warns that Foo is unused.

Checking what Rust does, it says that Foo is never constructed. So I'm think that in the case of structs, we don't need to check if they are referenced: we need to check if they are constructed. If not, then they are unused.

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@asterite asterite added the enhancement New feature or request label Sep 17, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 17, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 25, 2024
# Description

## Problem

Fixes #6055

## Summary

This is similar to how it works in Rust.

## Additional Context

## Documentation

Check one:
- [ ] No documentation needed.
- [x] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant