Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use $typ statements can be unquoted in ilegal positions #6059

Closed
Thunkar opened this issue Sep 17, 2024 · 0 comments · Fixed by #6064
Closed

use $typ statements can be unquoted in ilegal positions #6059

Thunkar opened this issue Sep 17, 2024 · 0 comments · Fixed by #6064
Labels
bug Something isn't working

Comments

@Thunkar
Copy link
Contributor

Thunkar commented Sep 17, 2024 •
edited
Loading

Expected Behavior

struct MyType {
    a: u64
}


comptime fn annotation(m: Module) -> Quoted {
    let typ = quote { MyType }.as_type();
    quote {
        use $typ;
    }
}

should return an error

Bug

It looks like this is the old "we don't error if we fail to parse everything" issue. So it just parses up to that use . For my example since the use is the first/only thing it just returns an empty list of statements

@jfecher

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@Thunkar Thunkar added the bug Something isn't working label Sep 17, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 17, 2024
@Thunkar Thunkar changed the title abi(tag) annotations on globals injected in module annotations are not honored use $typ statements can be unquoted in ilegal positions Sep 17, 2024
@jfecher jfecher mentioned this issue Sep 17, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 17, 2024
@jfecher
fix: Always parse all tokens from quoted token streams (#6064)
23ed74b 
# Description

## Problem\*

Resolves #5803
Resolves #6059

## Summary\*

If we ever had a token stream with a subset of valid input we'd parse
just that subset instead of erroring that the full input doesn't parse.

## Additional Context

We don't have EOF tokens in token streams so I used the `end()`
primitive instead.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Always parse all tokens from quoted token streams noir-lang/noir
1 participant
@Thunkar