Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric generics on trait methods results in failure to unify types #6100

Closed
TomAFrench opened this issue Sep 19, 2024 · 0 comments · Fixed by #6099
Closed

Numeric generics on trait methods results in failure to unify types #6100

TomAFrench opened this issue Sep 19, 2024 · 0 comments · Fixed by #6099

Comments

@TomAFrench
Copy link
Member

The nightly canary on some of the external libraries have been tripped:

https://github.com/noir-lang/noir_string_search/actions/runs/10937870108/job/30364704587
https://github.com/noir-lang/noir-edwards/actions/runs/10937805460/job/30364499322

┌─ src/lib.nr:3:43
  │
3 │ pub use utils::{conditional_select, lt_f, DebugRandomEngine};
  │                                           ----------------- DebugRandomEngine is private
  │

warning: cannot re-export DebugRandomEngine because it has less visibility than this use statement
  ┌─ src/lib.nr:3:43
  │
3 │ pub use utils::{conditional_select, lt_f, DebugRandomEngine};
  │                                           ----------------- consider marking DebugRandomEngine as pub
  │

error: Parameter #2 of method `match_chunks` must be of type [Field; HaystackChunks], not [Field; HaystackChunks]
    ┌─ src/lib.nr:170:[9](https://github.com/noir-lang/noir_string_search/actions/runs/10937870108/job/30364704587#step:4:10)
    │
170 │         haystack: [Field; HaystackChunks],
    │         --------
    │
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 19, 2024
@noir-lang noir-lang deleted a comment Sep 19, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2024
# Description

## Problem\*

Resolves #6100 

## Summary\*

It seems that #5156 has resulted in problems in unifying numeric
generics in trait impl methods.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant