Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nargo fmt crashes on non-ascii characters at line end #6108

Closed
nventuro opened this issue Sep 19, 2024 · 0 comments · Fixed by #6118
Closed

nargo fmt crashes on non-ascii characters at line end #6108

nventuro opened this issue Sep 19, 2024 · 0 comments · Fixed by #6118
Labels
bug Something isn't working

Comments

@nventuro
Copy link
Contributor

nventuro commented Sep 19, 2024 •
edited
Loading

Bug

The following programs all cause nargo fmt to crash:

//ç
//ñ
//¶

The error is:

The application panicked (crashed).
Message:  byte index 3 is not a char boundary; it is inside 'ç' (bytes 2..4) of `//ç
`
Location: tooling/nargo_fmt/src/visitor.rs:191
@nventuro nventuro added the bug Something isn't working label Sep 19, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 19, 2024
@jfecher jfecher mentioned this issue Sep 20, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 24, 2024
@jfecher @michaeljklein @TomAFrench
fix: Handle multi-byte utf8 characters in formatter (#6118)
b1d0619 
# Description

## Problem\*

Resolves #6108

## Summary\*



## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Michael Klein <lambdamichael@gmail.com>
Co-authored-by: Michael J Klein <michaeljklein@users.noreply.github.com>
Co-authored-by: TomAFrench <tom@tomfren.ch>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Handle multi-byte utf8 characters in formatter noir-lang/noir
1 participant
@nventuro