You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
…6243)
# Description
## Problem\*
Resolves#6242
## Summary\*
Making this PR for visibility to show that fixing this issue breaks our
serialize test.
Notably this fix allows rounding arithmetic generics using the `/ N * N`
pattern which was simplified away previously.
## Additional Context
I initially removed the cancellation of / and * entirely but found that
this breaks even more tests. So I added `approx_inverse` in a few cases
that only involve constants that I thought may be correct but we still
fail `serialize` even with these cases.
## Documentation\*
Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.
# PR Checklist\*
- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Aim
Expected Behavior
An error on the first call to
oops
and no error on the second.Bug
We get no error on the first call, and instead get an error on the second call despite
6 / 4 * 4 = 4
in integer arithmetic.To Reproduce
Workaround
None
Workaround Description
No response
Additional Context
No response
Project Impact
None
Blocker Context
No response
Nargo Version
No response
NoirJS Version
No response
Proving Backend Tooling & Version
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: