Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arithmetic generics assumes integer multiplication cancels integer division #6242

Closed
jfecher opened this issue Oct 8, 2024 · 0 comments · Fixed by #6243
Closed

Arithmetic generics assumes integer multiplication cancels integer division #6242

jfecher opened this issue Oct 8, 2024 · 0 comments · Fixed by #6243
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Oct 8, 2024

Aim

fn main() {
    oops::<6, 4>([1, 2, 3, 4, 5, 6]);

    // Expected type [Field; 6], found type [Field; 4]
    oops::<6, 4>([1, 2, 3, 4]);
}

// This gets erroneously simplified to `_x: [Field; N]` internally
fn oops<let N: u32, let M: u32>(_x: [Field; N / M * M]) {}

Expected Behavior

An error on the first call to oops and no error on the second.

Bug

We get no error on the first call, and instead get an error on the second call despite 6 / 4 * 4 = 4 in integer arithmetic.

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the bug Something isn't working label Oct 8, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 8, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2024
…6243)

# Description

## Problem\*

Resolves #6242

## Summary\*

Making this PR for visibility to show that fixing this issue breaks our
serialize test.

Notably this fix allows rounding arithmetic generics using the `/ N * N`
pattern which was simplified away previously.

## Additional Context

I initially removed the cancellation of / and * entirely but found that
this breaks even more tests. So I added `approx_inverse` in a few cases
that only involve constants that I thought may be correct but we still
fail `serialize` even with these cases.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant