feat(abi)!: merge both abi encoding/decoding methods #862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #851 (comment)
Description
Summary of changes
We've switched to tracking public inputs in the evaluator in
BTreeSet
rather than aVec
which naturally deduplicates them, this allows us to:WitnessMap
for both proving and verifying (before flattening this into an naturally deduped array for verification but we can remove this as well if the backends take aWitnessMap
for verifier inputs)The only sad thing about this PR is it brings back the boolean flag in the abi encoding functions (but we'll be able to handle this better with #678)
Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Additional context