Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abi)!: merge both abi encoding/decoding methods #862

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Feb 17, 2023

Related issue(s)

Resolves #851 (comment)

Description

Summary of changes

We've switched to tracking public inputs in the evaluator in BTreeSet rather than a Vec which naturally deduplicates them, this allows us to:

  • stop deduplicating these inputs manually up in the Nargo CLI.
  • always encode to a WitnessMap for both proving and verifying (before flattening this into an naturally deduped array for verification but we can remove this as well if the backends take a WitnessMap for verifier inputs)

The only sad thing about this PR is it brings back the boolean flag in the abi encoding functions (but we'll be able to handle this better with #678)

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

feat: deduplicate public inputs in evaluator
kevaundray
kevaundray previously approved these changes Feb 17, 2023
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- pending merge conflicts

@kevaundray kevaundray enabled auto-merge February 17, 2023 09:37
@kevaundray kevaundray added this pull request to the merge queue Feb 17, 2023
Merged via the queue into master with commit fecd32c Feb 17, 2023
@kevaundray kevaundray deleted the dedupe-public-inputs branch February 17, 2023 10:04
This was referenced Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants