feat: dynamic array indexing #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
requested changes
Feb 21, 2023
jfecher
reviewed
Feb 22, 2023
jfecher
reviewed
Feb 22, 2023
jfecher
reviewed
Feb 22, 2023
|
Looks like this PR is failing the 6_array test. Is it a bug or is it in need of another PR to acvm? |
|
Looks like we're using a feature which isn't stable in 1.66.0. |
We need an acvm release EDIT: in fact 6_array is failing verification, which may be linked to the may-be bb issue we have with verification... |
kevaundray
reviewed
Mar 20, 2023
kevaundray
reviewed
Mar 20, 2023
kevaundray
reviewed
Mar 20, 2023
kevaundray
reviewed
Mar 20, 2023
kevaundray
reviewed
Mar 20, 2023
Closed
jfecher
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Enable dynamic, i.e non constant, index for accessing arrays.
Memory operations are put in the memory trace and we apply memory consistency constraints on the sorted trace.
This PR requires an ACIR update
Test additions / changes
The integration test 6_arrays has been updated.
Checklist
cargo fmtwith default settings.EDIT: I have de-activated the feature in the PR:
The reason is that it is a long standing PR for which the test case it failing verification. This is probably another issue.
Not having this code merged in master is starting to become annoying.
The dynamic arrays will be activated by simply un-commenting the 2 above changes once the issue with verification is solved.