Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make noirc_driver aware of contracts #999

Merged
merged 3 commits into from
Mar 20, 2023
Merged

feat: make noirc_driver aware of contracts #999

merged 3 commits into from
Mar 20, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Followup PR for #966

Description

Summary of changes

Currently a lot of the compilation logic for contract lives inside nargo. In order to make them a first class citizen, ideally we'd be able to just tell the driver to compile the contracts within a crate similarly to how we can do for standard noir programs.

This PR then pushes much of this logic inside of noirc_driver so we just need to call driver.compile_contracts(&args.compile_options)

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench requested a review from jfecher March 17, 2023 13:13
@TomAFrench
Merge branch 'master' into push-contract-compile-into-driver
d9f0b65 
* master:
  chore: switch from mutable to immutable api for building paths (#1000)
  chore: pass keys to `save_key_to_dir` as slice (#1002)
  chore(noir): Release 0.3.2 (#986)
@TomAFrench
feat: use new compile_contracts method in wasm
3c79a80
@kevaundray kevaundray added this pull request to the merge queue Mar 20, 2023
@jfecher jfecher removed this pull request from the merge queue due to a manual request Mar 20, 2023
@jfecher jfecher added this pull request to the merge queue Mar 20, 2023
@jfecher jfecher merged commit c21afca into master Mar 20, 2023
@jfecher jfecher deleted the push-contract-compile-into-driver branch March 20, 2023 18:33
@kevaundray kevaundray mentioned this pull request Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomAFrench @jfecher @kevaundray