Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch from mutable to immutable api for building paths #1000

Merged
merged 1 commit into from
Mar 17, 2023
Merged

chore: switch from mutable to immutable api for building paths #1000

merged 1 commit into from
Mar 17, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Addresses all instances of noir-lang/acvm-backend-barretenberg#86 (comment) in nargo

Description

Summary of changes

I've replaced the instances of pushing onto mutable PathBufs with using the join api with immutable PathBufs. This is much clearer imo.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@kevaundray kevaundray added this pull request to the merge queue Mar 17, 2023
@kevaundray kevaundray merged commit 3637735 into master Mar 17, 2023
@kevaundray kevaundray deleted the path-refactor branch March 17, 2023 16:03
TomAFrench added a commit that referenced this pull request Mar 17, 2023
@TomAFrench
Merge branch 'master' into push-contract-compile-into-driver
d9f0b65 
* master:
  chore: switch from mutable to immutable api for building paths (#1000)
  chore: pass keys to `save_key_to_dir` as slice (#1002)
  chore(noir): Release 0.3.2 (#986)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @kevaundray