-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement 'open' and 'unconstrained' keywords #1037
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
changed the title
Implement 'open' and 'unconstrained' keywords
feat: Implement 'open' and 'unconstrained' keywords
Mar 27, 2023
vezenovm
reviewed
Mar 27, 2023
vezenovm
previously approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit
vezenovm
previously approved these changes
Mar 27, 2023
guipublic
reviewed
Mar 27, 2023
guipublic
approved these changes
Mar 27, 2023
This was referenced Jul 19, 2023
1 task
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #(none)
Description
Summary of changes
Adds the 'open' and 'unconstrained' keywords for contract visibility. These keywords are mutually exclusive and functions with neither keyword are considered to be 'secret' by default. It is an error for functions outside of a contract to specify that they are open or unconstrained (though we may allow unconstrained functions in the future).
These keywords currently do nothing until #1033 is merged, when they will only set the is_secret option in the resulting JSON after compiling a contract.
Dependency additions / changes
None
Test additions / changes
None
Checklist
cargo fmt
with default settings.Documentation needs
Once we document contracts, we will need to document that they can be secret (the default, no keyword),
open
, orunconstrained
.Additional context