Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow comptime or non comptime fields in unconstrained for loops #1172

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Apr 18, 2023

Related issue(s)

Resolves #

Description

The previous check for type checking unconstrained for loops erroneously always unified with a non-comptime Field which produced type errors when used with a comptime one.

This wasn't caught previously since numeric literals are polymorphically comptime and would just bind to CompTime::No previously. It would only trigger if using a variable which was explicitly declared with a comptime type like let a: comptime Field = 2;.

Summary of changes

Fixes the above check by unifying against a polymorphically comptime field instead of a non-comptime one.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@kevaundray kevaundray added this pull request to the merge queue Apr 18, 2023
Merged via the queue into master with commit 73df465 Apr 18, 2023
@kevaundray kevaundray deleted the jf/fix-unconstrained-indexing branch April 18, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants